Extras icon indicating copy to clipboard operation
Extras copied to clipboard

vt-uploader: Add version 0.1.9

Open kris3713 opened this issue 3 years ago • 2 comments

Closes #9349

kris3713 avatar Sep 28 '22 23:09 kris3713

/verify

kris3713 avatar Sep 28 '22 23:09 kris3713

All changes look good.

Wait for review from human collaborators.

vt-uploader

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Sep 28 '22 23:09 github-actions[bot]

/verify

kris3713 avatar Oct 02 '22 22:10 kris3713

All changes look good.

Wait for review from human collaborators.

vt-uploader

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Oct 02 '22 22:10 github-actions[bot]

/verify

kris3713 avatar Nov 25 '22 23:11 kris3713

All changes look good.

Wait for review from human collaborators.

vt-uploader

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Nov 25 '22 23:11 github-actions[bot]

/verify

kris3713 avatar Nov 26 '22 03:11 kris3713

All changes look good.

Wait for review from human collaborators.

vt-uploader

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Nov 26 '22 03:11 github-actions[bot]

@HUMORCE could you please test the manifest in my personal bucket? I need to know why the context menu I created for this manifest is not functioning properly?

scoop bucket add MyScoop 'https://github.com/Zliced13/MyScoop'; scoop install MyScoop/vt-uploader

kris3713 avatar Nov 26 '22 03:11 kris3713

why the context menu I created for this manifest is not functioning properly?

check the generated registry file finally.

btw:

1.why not use the package of portable one. 2.you should let the user choose whether to install the context menu or not, rather than forcing users to elevate privileges to do it, context menu is not a mandatory part. refer: main/7zip, extras/windows-terminal

p.s. I noticed that extras/windows-terminal installs the context menu automatic and no elevated privileges required, I will not use Scoop to install apps that include context menu or elevated privileges required.

I will not consider reviewing any manifests that require elevated privileges.'

  • Eliminates permission popup windows

  • Hides GUI wizard-style installers

  • Prevents PATH pollution from installing lots of programs

  • Avoids unexpected side-effects from installing and uninstalling programs

  • Finds and installs dependencies automatically

  • Performs all the extra setup steps itself to get a working program

    https://github.com/ScoopInstaller/Scoop#what-does-scoop-do

HUMORCE avatar Nov 26 '22 08:11 HUMORCE

If I get rid of the elevated privileges and forced context menu (make it optional). Then would you help me figure out my context menu problem?

kris3713 avatar Nov 26 '22 14:11 kris3713

Then would you help me figure out my context menu problem?

I have already told you for this...

HUMORCE avatar Nov 26 '22 15:11 HUMORCE

If I get rid of the elevated privileges and forced context menu (make it optional).

context menu without require elevated privileges is OK.

HUMORCE avatar Nov 26 '22 15:11 HUMORCE

/verify

kris3713 avatar Nov 26 '22 18:11 kris3713

All changes look good.

Wait for review from human collaborators.

vt-uploader

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Nov 26 '22 18:11 github-actions[bot]

Thank you, @HUMORCE, the context menu now works perfectly.

kris3713 avatar Nov 26 '22 18:11 kris3713

I used the setup package, because that one contains language files that could be helpful for non-English speakers. The portable package does not.

kris3713 avatar Nov 26 '22 18:11 kris3713

you might need to recreate a plain text format of install-context.reg replace current one, it's content cannot be tracked in the file changes.

HUMORCE avatar Nov 27 '22 10:11 HUMORCE

/verify

kris3713 avatar Nov 27 '22 17:11 kris3713

context menu without elevated privileges, and consider of global installation.

install-context.reg needs to changed to:

Windows Registry Editor Version 5.00

[HKEY_CURRENT_USER\Software\Classes\*\shell\Upload to VirusTotal\command]
@="\"$dir\\uploader.exe\" \"%1\""

I am not sure if this works with developer mode disabled. (Windows Settings > Privacy & security > For developer > Developer Mode )

Done, I changed it.

kris3713 avatar Nov 27 '22 17:11 kris3713

All changes look good.

Wait for review from human collaborators.

vt-uploader

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Nov 27 '22 17:11 github-actions[bot]

screenshot_20221127180221

fix it please

suggestion: create uninstall-context.reg when you do this.

sorry for I did not list all at once. thanks

HUMORCE avatar Nov 27 '22 18:11 HUMORCE

screenshot_20221127180221

fix it please

suggestion:

create uninstall-context.reg when you do this.

sorry for I did not list all at once. thanks

@HUMORCE download the file and you can see for yourself that I did change it.

https://github.com/ScoopInstaller/Extras/blob/174fb74f2ebd2374e0b8f8ffcfce43b34ad754ea/scripts/vt-uploader/install-context.reg

kris3713 avatar Nov 27 '22 19:11 kris3713

yes, but it is identified as a binary file, so we cannot viewing its changes.

is this file exported via regedit? this may be what caused it to be identified as a binary file, im not sure.

when correct: https://github.com/ScoopInstaller/Main/pull/4106/files#diff-8fee256e0fd73758f66ee53fa4ddaff6d04e97bfcd861204f61aaf53a9284312

HUMORCE avatar Nov 27 '22 20:11 HUMORCE

Done, @HUMORCE. The reg file is fixed now.

kris3713 avatar Nov 27 '22 20:11 kris3713

thanks for your work, I will refine this manifest when i am free.

HUMORCE avatar Nov 27 '22 21:11 HUMORCE