Extras icon indicating copy to clipboard operation
Extras copied to clipboard
verified publisher icon ScoopInstaller

spotify: Amend the procedure for blocking Spotify autoupdates

Open prasanthcakewalk opened this issue 8 months ago • 7 comments

Closes https://github.com/ScoopInstaller/Extras/issues/15471 (and possibly also https://github.com/ScoopInstaller/Extras/issues/12429). Relates to https://github.com/ScoopInstaller/Extras/issues/10841 and PR https://github.com/ScoopInstaller/Extras/pull/12737

Change 1: Instead of using "read-only" and "system" files attributes (which Spotify doesn't respect) to block the deletion of the file named Update, the icacls command is used to deny delete permissions to the current user for this file. I've verified that Spotify doesn't delete this file on startup anymore.

Change 2: The Remove-Item commands have been modified to work without pausing for user input, regardless of whether Update is a file or a directory. Also, all the commands related to autoupdate blocking have been set to not print error messages on failure (to avoids issues like https://github.com/ScoopInstaller/Extras/issues/11216)

  • [X] Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • [X] I have read the Contributing Guide

prasanthcakewalk avatar May 18 '25 21:05 prasanthcakewalk

All changes look good.

Wait for review from human collaborators.

spotify

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar May 18 '25 21:05 github-actions[bot]

I'll fix the failing tests within a couple of days!

prasanthcakewalk avatar May 23 '25 03:05 prasanthcakewalk

/verify

prasanthcakewalk avatar May 24 '25 12:05 prasanthcakewalk

Your changes do not pass checks.

spotify

  • [x] Description
  • [x] License
  • [ ] Hashes
  • [ ] Checkver
  • [x] Autoupdate

github-actions[bot] avatar May 24 '25 12:05 github-actions[bot]

/verify

prasanthcakewalk avatar May 24 '25 13:05 prasanthcakewalk

All changes look good.

Wait for review from human collaborators.

spotify

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar May 24 '25 13:05 github-actions[bot]

@HUMORCE Can you please take a look at the updated PR when you have the chance? I can confirm that this blocked Spotify's latest automatic update for me, so this would close https://github.com/ScoopInstaller/Extras/issues/15471 and https://github.com/ScoopInstaller/Extras/issues/12429.

prasanthcakewalk avatar Jun 04 '25 13:06 prasanthcakewalk

/verify

prasanthcakewalk avatar Jun 26 '25 19:06 prasanthcakewalk

All changes look good.

Wait for review from human collaborators.

spotify

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Jun 26 '25 19:06 github-actions[bot]