Extras icon indicating copy to clipboard operation
Extras copied to clipboard

v2rayn: Change behaviors of preinstall

Open ProjektMing opened this issue 1 year ago • 1 comments

For previous pre_uinstall cause dependence on app's specific version, I consider using SymbolicLink instead of HardLink. I've checked on my PC and got no problems so far.

ProjektMing avatar Sep 24 '24 09:09 ProjektMing

All changes look good.

Wait for review from human collaborators.

v2rayn

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Sep 24 '24 09:09 github-actions[bot]

Note that if you create symbolic links, the app's built-in update feature might overwrite Scoop's Xray-core (and other core) installations. I think hard link is much safer.

Related:

  • #13969

stevenlele avatar Oct 25 '24 06:10 stevenlele

@ProjektMing @stevenlele has a good point:

Symbolic links can only be created by:

  1. Administrators: By default, creating symbolic links requires administrative privileges.

  2. Developer Mode: If Developer Mode is enabled, non-administrative users can create symbolic links without requiring elevated privileges. Developer Mode grants the SeCreateSymbolicLinkPrivilege to regular users.

  3. Manually Assigning Privileges: Non-administrative users can be granted the SeCreateSymbolicLinkPrivilege manually through Local Group Policy Editor or other privilege assignment tools. This allows them to create symbolic links without enabling Developer Mode or having admin rights.

rasa avatar Dec 29 '24 17:12 rasa

Understood. I just saw hardlink make it hard to upgrade independently, but ignored other factors.

ProjektMing avatar Dec 29 '24 21:12 ProjektMing