StructuralIdentifiability.jl icon indicating copy to clipboard operation
StructuralIdentifiability.jl copied to clipboard

Expression of a function in terms of generators of rational function field (bug fix)

Open pogudingleb opened this issue 1 year ago • 1 comments

Alexey Ovchinnikov has reported the failure of an assertion during reparametrization on

ode = @ODEmodel(
    x'(t) = b * (x(t)^2 + 1) / (2 * a),
    y(t) = 2 * x(t) / (b * (1 + x(t)^2))
)

The problem was with computing the expressions of rational function wrt the tag variables, it is fixed.

pogudingleb avatar Apr 08 '24 22:04 pogudingleb

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.09%. Comparing base (08dabc1) to head (e471b8c). Report is 2 commits behind head on master.

Files Patch % Lines
src/util.jl 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
+ Coverage   90.04%   90.09%   +0.05%     
==========================================
  Files          28       28              
  Lines        3306     3313       +7     
==========================================
+ Hits         2977     2985       +8     
+ Misses        329      328       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 08 '24 22:04 codecov[bot]