SimpleNonlinearSolve.jl icon indicating copy to clipboard operation
SimpleNonlinearSolve.jl copied to clipboard
verified publisher icon SciML

Force ADTypes v1

Open gdalle opened this issue 1 year ago • 1 comments

Checklist

  • [x] Appropriate tests were added
  • [x] Any code changes were done in a way that does not break public API
  • [x] All documentation related to code changes were updated
  • [x] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
  • [x] Any new documentation only uses public API

Additional context

Force the use of ADTypes v1 instead of allowing v0.2 as well. I don't think this requires internal changes for this package, but it will break downstream.

gdalle avatar May 16 '24 06:05 gdalle

@ChrisRackauckas can you approve the workflows?

gdalle avatar May 16 '24 09:05 gdalle

@avik-pal can you handle the unexpected passes? https://github.com/SciML/SimpleNonlinearSolve.jl/actions/runs/9128228158/job/25100141056?pr=143#step:6:670

ChrisRackauckas avatar May 17 '24 13:05 ChrisRackauckas

This is that strange issue where Mac behaves differently from other OS. Setting them to pass in Mac will cause Windows and Linux to fail

avik-pal avatar May 17 '24 13:05 avik-pal

At least setup an if Mac then not broken so tests pass

ChrisRackauckas avatar May 17 '24 14:05 ChrisRackauckas