RecursiveArrayTools.jl icon indicating copy to clipboard operation
RecursiveArrayTools.jl copied to clipboard

remove functions that are predefined with `abstractarray` interface

Open vpuri3 opened this issue 3 years ago • 6 comments

unless there's performance diff

vpuri3 avatar Jan 31 '22 12:01 vpuri3

All Core tests passed on my MBP

vpuri3 avatar Jan 31 '22 12:01 vpuri3

What's the performance difference?

ChrisRackauckas avatar Jan 31 '22 13:01 ChrisRackauckas

i don't see any. i meant to say "remove those functions unless there is a performance difference for for a particular use case".

vpuri3 avatar Jan 31 '22 13:01 vpuri3

Could you post some benchmarks?

ChrisRackauckas avatar Jan 31 '22 14:01 ChrisRackauckas

Here are some benchmark examples I care about in case someone wants to check performance impact: https://github.com/SciML/RecursiveArrayTools.jl/issues/160

mateuszbaran avatar Apr 08 '22 13:04 mateuszbaran

thanks will get to it

vpuri3 avatar Apr 08 '22 14:04 vpuri3