ModelingToolkitStandardLibrary.jl icon indicating copy to clipboard operation
ModelingToolkitStandardLibrary.jl copied to clipboard

fixes Symbolics deprecation

Open ValentinKaisermayer opened this issue 3 years ago • 3 comments

ValentinKaisermayer avatar Aug 19 '22 15:08 ValentinKaisermayer

Bump the symbolics lower bound?

ChrisRackauckas avatar Aug 19 '22 21:08 ChrisRackauckas

Seems to be an MTK issue with inputs_to_parameters! and array variables. The StateSpace block is the only one using it. @baggepinnen can you have a look?

ValentinKaisermayer avatar Aug 20 '22 12:08 ValentinKaisermayer

Why doesn't the downstream test fail in MTK?

ValentinKaisermayer avatar Aug 20 '22 12:08 ValentinKaisermayer

Codecov Report

Merging #99 (41bf9cf) into main (20366a7) will increase coverage by 1.31%. The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   65.60%   66.92%   +1.31%     
==========================================
  Files          23       24       +1     
  Lines        1006     1052      +46     
==========================================
+ Hits          660      704      +44     
- Misses        346      348       +2     
Impacted Files Coverage Δ
src/Blocks/utils.jl 57.14% <50.00%> (ø)
src/Blocks/continuous.jl 98.17% <100.00%> (ø)
src/Mechanical/Rotational/sources.jl 85.00% <0.00%> (-15.00%) :arrow_down:
src/Mechanical/Rotational/sensors.jl 100.00% <0.00%> (ø)
src/Mechanical/Rotational/utils.jl 73.46% <0.00%> (+2.04%) :arrow_up:
src/Mechanical/Rotational/components.jl 88.88% <0.00%> (+2.77%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 03 '22 18:09 codecov[bot]

Seems like a real failure?

ChrisRackauckas avatar Sep 06 '22 09:09 ChrisRackauckas

Seems like a real failure?

Yes, but in MTK.

ValentinKaisermayer avatar Sep 06 '22 21:09 ValentinKaisermayer