ModelingToolkitStandardLibrary.jl icon indicating copy to clipboard operation
ModelingToolkitStandardLibrary.jl copied to clipboard

adds missing rotational components

Open ValentinKaisermayer opened this issue 3 years ago • 11 comments

Added Components:

Components

  • RotationalFriction

Sources

  • Torque
  • Speed

Sensors

  • AngleSensor
  • SpeedSensor
  • TorqueSensor
  • RelSpeedSensor

ValentinKaisermayer avatar Jun 10 '22 17:06 ValentinKaisermayer

Closes #28

ValentinKaisermayer avatar Jun 10 '22 17:06 ValentinKaisermayer

Codecov Report

Merging #75 (18d9e95) into main (20366a7) will increase coverage by 1.31%. The diff coverage is 93.61%.

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   65.60%   66.92%   +1.31%     
==========================================
  Files          23       24       +1     
  Lines        1006     1052      +46     
==========================================
+ Hits          660      704      +44     
- Misses        346      348       +2     
Impacted Files Coverage Δ
src/Mechanical/Rotational/utils.jl 73.46% <ø> (+2.04%) :arrow_up:
src/Mechanical/Rotational/sources.jl 85.00% <80.00%> (-15.00%) :arrow_down:
src/Mechanical/Rotational/components.jl 88.88% <100.00%> (+2.77%) :arrow_up:
src/Mechanical/Rotational/sensors.jl 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jun 10 '22 19:06 codecov[bot]

Conflicts

ChrisRackauckas avatar Jun 19 '22 16:06 ChrisRackauckas

I have run format("."), no idea why it still complains.

ValentinKaisermayer avatar Jun 28 '22 19:06 ValentinKaisermayer

@YingboMa any ideas?

ChrisRackauckas avatar Jun 28 '22 19:06 ChrisRackauckas

Are you sure you are using JuliaFormater 1.0?

YingboMa avatar Jun 28 '22 20:06 YingboMa

The PR does not even touch the file it complains about.

ValentinKaisermayer avatar Jun 28 '22 20:06 ValentinKaisermayer

Are you sure you are using JuliaFormater 1.0?

v1.0.3

ValentinKaisermayer avatar Jul 07 '22 07:07 ValentinKaisermayer

Tried with v1.0.5

julia> format(".")
true

ValentinKaisermayer avatar Jul 07 '22 07:07 ValentinKaisermayer

@ValentinKaisermayer check that the Julia environment from which you call JuliaFormatter is using you deved version of MTKStdlib, I just ran into a similar problem where JuliaFormatter ran on the latest released version of MTK instead of my local copy :P

baggepinnen avatar Jul 18 '22 11:07 baggepinnen

I'm pretty sure it is the correct folder. The package folder is read only, isn't it?

ValentinKaisermayer avatar Jul 18 '22 18:07 ValentinKaisermayer