Integrals.jl
Integrals.jl copied to clipboard
Docs
Firstly, thanks for making this fantastic package! It's great to have the various quadrature / cubature packages accessible via a common interface.
The docs are currently a little harder to parse than they could be though. In particular:
- The first example in the readme is kind of hard to parse because it's not explained what each of the arguments does until further down in the README. It would be helpful if there was at least quickly suggested that the first argument is the function you want to integrate, the second lower bound(s), and the third upper bound(s).
- the second example is quite hard to parse, and I'm still not quite sure a) what format I can expect
xto have and b) what format I can expectdxto have, as this doesn't appear to be documented. An explanation of precisely what I should assume about the structure ofx, anddx(presumably as a function ofx?) would be greatly appreciated. - assumptions about
fwhen a parameter is not needed. It would be helpful to explicitly state that you still need to have an argument infthat is the parameters, assuming I've understood this correctly. - 1, 2 and 3 would be greatly appreciated in docstring-form, in conjunction with the information in the
QuadratureProblemsection of the README. -
solvedoesn't appear to be properly documented anywhere, although I'll grant you that it's pretty obvious how to use it from the example. Regardless, at least the presence of a docstring would be great. - It's unclear what to do with the output type of a successful
solvecall. I think theufield is the thing I'm after, but I don't really know? It looks like this is defined inDiffEqBase, so maybe the docs already exist for it? If so, it would be great if they could be linked. Again, maybe a docstring for the type?
Thanks again for the package!
All good suggestions. Quite busy right now but these should all be done.
To add to the list above
- What happens if kwargs are passed to
QuadratureProblem? I think currently they are not used anywhere.
They should splat in like any other kwargs. It's not fully handled right now.
I think most of this is implemented now?