DiffEqProblemLibrary.jl icon indicating copy to clipboard operation
DiffEqProblemLibrary.jl copied to clipboard

Update Bruss for a new release of DiffEqOperators.jl

Open YingboMa opened this issue 6 years ago • 5 comments

The API of DerivativeOperator has been changed.

https://github.com/JuliaDiffEq/DiffEqProblemLibrary.jl/blob/master/src/ode/brusselator_prob.jl#L100-L107

YingboMa avatar Jul 16 '19 22:07 YingboMa

Should we make a constructor of DerivativeOperator instead that acts as compatibility for such cases? We don't even have this stuff documented and this kind of change is scary.

kanav99 avatar Aug 08 '19 17:08 kanav99

should it even use the DerivativeOperator?

ChrisRackauckas avatar Aug 10 '19 00:08 ChrisRackauckas

I just replaced

DerivativeOperator{Float64}(2,2,1/(N_brusselator_1d-1),
                                      N_brusselator_1d,
                                      :Dirichlet,:Dirichlet;
                                      BC=(1.,1.))

with

CenteredDifference{Float64}(2,2,1/(N_brusselator_1d-1),N_brusselator_1d)

and it worked for OrdinaryDiffEq tests. Is it right?

kanav99 avatar Aug 10 '19 15:08 kanav99

yes that's good. PR.

ChrisRackauckas avatar Aug 10 '19 15:08 ChrisRackauckas

Still not completely fixed since I forgot it needs BCs as well

ChrisRackauckas avatar Aug 10 '19 16:08 ChrisRackauckas