memilio icon indicating copy to clipboard operation
memilio copied to clipboard

Parameters in ABM simulation aren't set correctly.

Open DavidKerkmann opened this issue 2 years ago • 0 comments

Motivation / Current Behaviour

In the setting of the parameters in the simulation, there is some code duplication and some unclear parameter settings. We have

infection_params.get<mio::abm::InfectedNoSymptomsToSymptoms>()[{mio::abm::VirusVariant::Wildtype,
                                                                    mio::abm::AgeGroup::Age0to4}]  = 0.276;

and later

infection_params.get<mio::abm::InfectedNoSymptomsToSymptoms>()[{mio::abm::VirusVariant::Wildtype,
                                                                    mio::abm::AgeGroup::Age0to4}]  = 0.161;

Similar with other parameters. This duplication/error probably stems from the removal of vaccination as a part of the parameters. These parameters currently represent a time per day, so this would be only a couple of hours in this case, but some other parameters are even lower and all of them seem to be wrong.

Enhancement description

Perhaps they are supposed to be the percentage of people that transition to these compartments rather than the time spent. Someone should have a look at this, in particular we need fitting values once #664 gets merged.

Additional context

No response

Checklist

  • [X] Attached labels, especially loc:: or model:: labels.
  • [X] Linked to project

DavidKerkmann avatar Oct 26 '23 14:10 DavidKerkmann