memilio icon indicating copy to clipboard operation
memilio copied to clipboard

1290 add ABM visualization from paper to memilio plot

Open xsaschako opened this issue 8 months ago • 4 comments

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • add visualization for the abm runs.

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • [x] Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • [x] New code adheres to coding guidelines
  • [x] No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • [x] Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • [x] Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • [x] Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • [x] (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • [ ] Corresponding issue(s) is/are linked and addressed
  • [ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • [ ] Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • [ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • [ ] On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

xsaschako avatar May 27 '25 22:05 xsaschako

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.28%. Comparing base (83c57ad) to head (392ec54).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1291   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files         168      168           
  Lines       14858    14858           
=======================================
  Hits        14454    14454           
  Misses        404      404           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 27 '25 23:05 codecov[bot]

Thanks for bringing this close to our previous plot style from the assessment paper. @jubicker Could you have a look for the detailed review?

mknaranja avatar May 30 '25 10:05 mknaranja

There is one CI check failing (Which is not failing on the main).

jubicker avatar Jun 23 '25 06:06 jubicker

This needs documentation changes

xsaschako avatar Jul 29 '25 08:07 xsaschako