memilio icon indicating copy to clipboard operation
memilio copied to clipboard

Inside demonstrator Munich

Open jubicker opened this issue 1 year ago • 1 comments

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Inside demonstrator for munich

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • [ ] Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • [ ] New code adheres to coding guidelines
  • [ ] No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • [ ] Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • [ ] Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • [ ] Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • [ ] (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • [ ] Corresponding issue(s) is/are linked and addressed
  • [ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • [ ] Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • [ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • [ ] On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

jubicker avatar Jan 02 '25 08:01 jubicker

Codecov Report

Attention: Patch coverage is 66.75749% with 122 lines in your changes missing coverage. Please review.

Project coverage is 95.12%. Comparing base (f192ec6) to head (af7bcbd). Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
cpp/models/abm/analyze_result.h 0.00% 79 Missing :warning:
cpp/models/abm/parameters.h 78.67% 29 Missing :warning:
cpp/models/abm/infection.cpp 87.82% 14 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1169      +/-   ##
==========================================
- Coverage   96.97%   95.12%   -1.85%     
==========================================
  Files         148      148              
  Lines       13718    13876     +158     
==========================================
- Hits        13303    13200     -103     
- Misses        415      676     +261     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 07 '25 08:01 codecov[bot]