1073 Remove credentials from Population Data Download
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
- remove credentials
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
- [ ] Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
- [ ] New code adheres to coding guidelines
- [ ] No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
- [ ] Tests are added for new functionality and a local test run was successful (with and without OpenMP)
- [ ] Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
- [ ] Proper attention to licenses, especially no new third-party software with conflicting license has been added
- [ ] (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.
Checks by code reviewer(s)
- [ ] Corresponding issue(s) is/are linked and addressed
- [ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
- [ ] Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
- [ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
- [ ] On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).
Closes #1073
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.14%. Comparing base (
7d46233) to head (0cc642a). Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1074 +/- ##
=======================================
Coverage 96.14% 96.14%
=======================================
Files 131 131
Lines 11047 11049 +2
=======================================
+ Hits 10621 10623 +2
Misses 426 426
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@patricklnz and why have the credentials been removed? please provide details and also always check boxes! please also check this always @jubicker :)