sass-convert icon indicating copy to clipboard operation
sass-convert copied to clipboard

Whitespace inconsistency error not thrown

Open ghost opened this issue 10 years ago • 1 comments

First off: I love this package, and I've found it incredibly helpful. Thank you guys for your hard work.

This is something I stumbled upon: Any whitespace inconsistencies will cause the conversion to "complete", but the file with whitespace inconsistencies is not converted, nor are any sibling files in the same directory. I'm using "sass-convert" as part of a gulp task. I ended up running SASS's "sass-convert" command line tool, which threw an error indicating that there was a whitespace inconsistency.

Should this throw an error and end the conversion instead of failing silently? Or is anyone else having issues recreating this?

ghost avatar Aug 19 '15 21:08 ghost

Hey,

thanks for the report. This is indeed a wrong behavior, any error or notice from the sass-convert binary should be caught and printed to the end user. Unconverted files should not be passed through the stream.

nor are any sibling files in the same directory

This is weird.

Anyway, we will need to run some tests and debugging.

pascalduez avatar Aug 20 '15 12:08 pascalduez