bake icon indicating copy to clipboard operation
bake copied to clipboard

Minor "BAKE_ARCHITECTURE" vs. "BAKE_ARCH" inconsistency

Open heybdj opened this issue 5 years ago • 1 comments

See: https://github.com/SanderMertens/bake/blob/ef8b8809f1cf5594323807a90513c557a9a7f7ee/util/src/load.c#L1063

Bake's README lists "BAKE_ARCHITECTURE" as the environment variable used to specify processor architecture, but the line referenced above stores the initialized value in "BAKE_ARCH".

Would it be okay to submit a PR that corrects this? If you suspect that user code uses both "BAKE_ARCHITECTURE" and "BAKE_ARCH", we could maintain compatibility like this:

ut_setenv("BAKE_ARCH", UT_ARCH);
ut_setenv("BAKE_ARCHITECTURE", UT_ARCH);

...but it would be nice to simply replace "BAKE_ARCH" and have one definitive variable, if that sounds safe.

Cheers! ☺️

heybdj avatar May 22 '20 19:05 heybdj

Sounds good to me!

SanderMertens avatar May 27 '20 06:05 SanderMertens