commander-cli icon indicating copy to clipboard operation
commander-cli copied to clipboard
verified publisher icon SamuelSchlesinger

Better Tests

Open SamuelSchlesinger opened this issue 5 years ago • 8 comments

I just expand the unit testing that I'm doing right now, and maybe include one integration tests with runningtask-manager or something.

SamuelSchlesinger avatar Jun 10 '20 22:06 SamuelSchlesinger

I converted all the tests to hspec in #15, maybe this should be split into two pulls.

Take a look and let me know what you think.

BebeSparkelSparkel avatar Dec 10 '20 14:12 BebeSparkelSparkel

Will do! Sorry for taking so long to reply again, I've been busy with work and holiday stuff.

SamuelSchlesinger avatar Dec 27 '20 20:12 SamuelSchlesinger

That one was closed, telling me which one covers it would be helpful.

SamuelSchlesinger avatar Dec 27 '20 20:12 SamuelSchlesinger

Most of the new PRs have the hspec tests already and have been rebased to have the hspec tests

BebeSparkelSparkel avatar Dec 27 '20 21:12 BebeSparkelSparkel

Can you tell me the best order in which to read the PRs? As I now see them, some are far too large for me to feel comfortable with merging as they are.

SamuelSchlesinger avatar Dec 27 '20 21:12 SamuelSchlesinger

oldest to newest. If that is too much let me know

BebeSparkelSparkel avatar Dec 27 '20 21:12 BebeSparkelSparkel

I think that's fine, actually. I am waiting to hear back from you on the oldest now.

SamuelSchlesinger avatar Dec 27 '20 21:12 SamuelSchlesinger

I have restructured most off the pull requests and removed the PRs that you indicated had too many changes. This starts with PR #31 and each PR lists which PR should precede it.

BebeSparkelSparkel avatar Dec 30 '20 12:12 BebeSparkelSparkel