carbon icon indicating copy to clipboard operation
carbon copied to clipboard

Impossible to change height of Filterable Select

Open WojciechMichalowski opened this issue 3 years ago • 5 comments

Desired behaviour

https://carbon.sage.com/?path=/docs/select-filterable--default-story#new-designs-validation Zrzut ekranu 2022-06-23 o 13 52 55

Current behaviour

height is hardcoded (dropdown)

Suggested Solution

add prop to change height

CodeSandbox or Storybook URL

No response

Anything else we should know?

No response

Confidentiality

  • [X] I confirm there is no confidential or commercially sensitive information included.

WojciechMichalowski avatar Jun 23 '22 11:06 WojciechMichalowski

@harpalsingh Do we want to be allow users to control the height of the dropdown of Select?

DipperTheDan avatar Jun 28 '22 12:06 DipperTheDan

@ljemmo Could you advise on this please?

nicktitchmarsh avatar Aug 02 '22 13:08 nicktitchmarsh

@nicktitchmarsh, @WojciechMichalowski and @DipperTheDan do we know why this override was requested? I believe the current hardcoded height is by design. I think if there's enough of a strong rationale, then we could certainly consider adding this in.

ljemmo avatar Aug 02 '22 15:08 ljemmo

overside is bcs of figma designs

WojciechMichalowski avatar Aug 12 '22 06:08 WojciechMichalowski

Jira Ticket issue: SBS-35835

rawlmp avatar Aug 12 '22 08:08 rawlmp

Hi All, For context, I'd just like to provide some justification as to why this override has been requested and the design problem we are facing due to the current limitation...

The UI is built with the primary purpose of enhancing productivity for our users processing their data. Assigning things to a given row is the primary function and this is the most frequent action a user will perform in the product

We have included a supporting message description for each assignment which can be toggled on or off by preference and has tested well. However, this does mean that at any one time a user can only view one assignment in the drop-down list even though on a larger monitor we have the real estate to reduce unnecessary scrolling.

lukepricesage avatar Aug 15 '22 17:08 lukepricesage

@lukepricesage Thanks for the context.

@nicktitchmarsh - i think it makes sense for carbon to add an optional height override prop for Luke to achieve this. However, please can we make sure that by default we maintain the prior height as default.

ljemmo avatar Aug 15 '22 17:08 ljemmo

:tada: This issue has been resolved in version 110.9.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

carbonci avatar Sep 16 '22 13:09 carbonci