[Bug?] SecuROM (Old) detected on Sims 3: Generations update file.

[PurpleNekoNova]

Submitting at request of null http://redump.org/disc/43745/

F:data1.hdr\isrt.dll: PE Compact v20240 (internal version) F:data1.hdr\The Sims 3 Generations_code.exe: EA CdKey Registration Module 1.08.05.00 F:data1.hdr\The Sims 3 Generations_uninst.exe: EA CdKey Registration Module 1.08.05.00 F:Game\Bin\Sims3EP04GDF.dll: CExe F:ISSetup.dll: PE Compact v20240 (internal version) F:Support\EADM\eadm-installer.exe: NSIS v2.33-Unicode F:Support\Updates\TS3_1.21.123.0110xx_update.exe: SecuROM (very old, v3 or less)

[Morlit55]

Had another false positive in regards to this and Its apparently related to this line of code.

if (pex.OverlayStrings != null)
            {
                if (pex.OverlayStrings.Any(s => s == "AddD"))
                    return $"SecuROM {GetV4Version(pex)}";
            }

What's happening is that BOS reports discs as having SecuROM as long as the condition is fulfilled. Even if "AddD" is there for other reasons.

[Morlit55]

New development to this.

Latest Rolling BoS reports "SecuROM (very old, v3 or less)" for http://redump.org/disc/127238/ and nothing more. But this is a legit SecuROM 4.85.04 game as reported by PiD and supported by the fact that the disc also has SecuROM DPM info.

[mnadareski]

May be fixed as of https://github.com/SabreTools/BinaryObjectScanner/commit/9af871c0ffb57019428e59358e7c1e8cdb57b1b8

[Morlit55]

Does not seem to have been fixed.

http://redump.org/disc/127924/ Reported a "SecuROM (very old, v3 or less), " false positive as well.

[mnadareski]

@PurpleNekoNova and @Morlit55, stricter parsing should alleviate this: https://github.com/SabreTools/BinaryObjectScanner/commit/19e696bf15d18d44f7af040e21124759add38918