Changes in registries do not reflect on existing images

[vamitrou]

Netbox version	Plugin Version	Agent version	Docker API Version
3.6.9		1.6.1	1.45

Actual Behavior

After changing the properties of a registry and trying to pull an already defined image it won't use the new properties (e.g. registry server address) but they have the previous configuration cached. For pulling the image correctly it has to be deleted and recreated.

Desired Behavior

When doing changes in a registry, the images already defined should make use of the new changes.

How to reproduce

1. Create a registry with no username/password and an invalid server address URL like https://registry.example.com.
2. Create an image using that registry and force pull. You will see the docker login required in the journal.
3. Go back to registry and put the correct URL like https://registry.mygitlab.int, add proper username and password.
4. Go back to the image and force pull again. You will see in the journal it tries to pull the image from the public docker registry.

[lvenier]

@vamitrou Thank you for your issue. This one will not be an easy one to manage. Editing a registry will require to handle the current with those registries to be updated. We'll discuss it to see what we can do.