Added Custom loading image view option for SVProgressHUD with example

[wooyukit]

Added Custom loading image view option for SVProgressHUD with example as below.

[859988748]

you forget to update hud view frame when there are both animating img and status string.

[wooyukit]

Dear 859988748,

Thanks for your advice. I fixed the version and committed. Please check

it if you are free.

Thanks and Regards,

Kit

2016-07-22 12:24 GMT+08:00 859988748 [email protected]:

you forget to update hud view frame when there are both animating img and status string.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SVProgressHUD/SVProgressHUD/pull/644#issuecomment-234451582, or mute the thread https://github.com/notifications/unsubscribe-auth/ALNDswlYSOTUTvwmnpMUHrFaT0fsUjNJks5qYEYFgaJpZM4JOZIB .

[859988748]

Thanks for your rapid response.

Maybe you want to enlarge the black hud view frame when using an image with 90pt * 90 pt, cause, the animation image will be clipped

[wooyukit]

I think it should be ok.

[859988748]

sorry, forget to setMinimumSize.

solved

[wooyukit]

Thanks. In the example, I set the MinimumSize when selected the custom animation type. Actually, I can set the size depending on the loadingImageView size.

[859988748]

if you don't set MinimumSize, the problem I found may happened. Seems can't auto fit image size.

[wooyukit]

Yes. I can set the size depending on the image size.

[859988748]

Fix the size problem would be better.

I'm trying to fix that. I think it needs to be compatible with string only mode and string and Image mode. Kind of more code need to be written.

[wooyukit]

The Updated version is committed. Updated the HUD size depending on the custom loading image view size.

[honkmaster]

Thanks for great idea. However from my opinion this is way off for the HUD as we want to keep it very simple. In addition a question: Why not use a Gif and why do you use 11 images?

[wooyukit]

Because of the needs of my custom situation, I have to add the custom loading image. Furthermore, this plugin is so popular. I think other people may have the same need as me so I share it to public. Since the quality of png is better than the Gif image, I use png image sequence rather than Gif.

[honkmaster]

I understand and would merge. However, for the demo we must get rid of the xcassets as we support iOS downto version 6. Otherwise I will start to review this PR, as I like it now a little more after thinking about it. In addition: You need to add some documentation (e.g. Readme.md) to help others use this.

[wooyukit]

Got it. I will prepare the readme file and place the images into resource folder avoiding using the xcassets.

[honkmaster]

Any feedback regarding the requested changes?

[RAGOpoR]

Not ready for merge?