open_framework icon indicating copy to clipboard operation
open_framework copied to clipboard

Fix typo in breadcrumb_classes setting

Open lennart opened this issue 12 years ago • 3 comments

This pull-request will sanitize the option value accepted by the theme setting breadcrumb_classes by removing the trailing space.

I know this is not backwards compatibly, but please think about adjusting your last change to a more sane option-value. Maybe one could run a migration on updating the theme, but I am not that much into maintaining Drupal Modules. If you can lead the way, I am happy to integrate a simple migration that fixes existing database values as well.

The two commits fix the theme settings admin pane (theme-settings.php) and the interpretation of the value inside template.php

Best regards and keep up the good work,

Lennart

lennart avatar Oct 18 '13 08:10 lennart

Thanks @lennart ! @hyperboy can you take a look at this pull request when you have a chance?

meganem avatar Oct 28 '13 20:10 meganem

Risk is that a page template is checking using an if/then statement using the existing value and it would not recognize the new value.

We would need to make sure to support backwards compatibility on this, so probably not merging right now.

meganem avatar Mar 12 '14 18:03 meganem

Because of our hosting ecosystem which does automatic theme updates, we have to have a backwards compatible solution. :/ Tabled for a potential future release..

meganem avatar Jan 29 '15 21:01 meganem