ScratchTools icon indicating copy to clipboard operation
ScratchTools copied to clipboard

New Home Page

Open ccocks opened this issue 1 year ago • 77 comments

I will make more styles soon but for now its just a nicer home page.

ccocks avatar Jun 21 '24 20:06 ccocks

Could you provide a picture...?

cally-jt avatar Jun 21 '24 21:06 cally-jt

I cannot test what it looks like but maybe you can. I know it looks good...

ccocks avatar Jun 21 '24 21:06 ccocks

Screenshot 2024-06-21 at 5 15 42 PM

Could you provide a picture...?

The hover effect is nice, but the colors could be improved...

MaterArc avatar Jun 21 '24 21:06 MaterArc

How did you make it if you didnt test it? And no i cannot provide one since i dont have access to a pc rn

cally-jt avatar Jun 21 '24 21:06 cally-jt

Screenshot 2024-06-21 at 5 15 42 PM

Could you provide a picture...?

The hover effect is nice, but the colors could be improved...

Ok yea this should be improved before possible merge

cally-jt avatar Jun 21 '24 21:06 cally-jt

Wait somethings wrong..

ccocks avatar Jun 21 '24 21:06 ccocks

Screenshot 2024-06-21 at 5 15 42 PM > Could you provide a picture...?

The hover effect is nice, but the colors could be improved...

Ok yea this should be improved before possible merge

For sure, yeah. I assume this isn't the finished result. I also added the white text color to the css before injecting it because before the contrast wasn't the best.

MaterArc avatar Jun 21 '24 21:06 MaterArc

Possible ideas

  • make each section a different colour instead of 1 bland orange
  • add a bigger contrast between the "view all" button and background

cally-jt avatar Jun 21 '24 21:06 cally-jt

blacks more readable on orange

ccocks avatar Jun 21 '24 21:06 ccocks

add a bigger contrast between the "view all" button and background add "!important" on line 19. The View all should be black

ccocks avatar Jun 21 '24 21:06 ccocks

View Image ![image](https://github.com/STForScratch/ScratchTools/assets/96586789/d82be5a0-0451-4697-aa4f-70efee547fc0) Black on orange ![image](https://github.com/STForScratch/ScratchTools/assets/96586789/5b18a66f-290b-42a4-a3a3-d1f6f6323220) White on orange

ccocks avatar Jun 21 '24 21:06 ccocks

image

Black on orange

image

White on orange

It isnt white tho, its a dark blue which id even more unreadable

cally-jt avatar Jun 21 '24 21:06 cally-jt

The view all button and the box header should both be black. My original code was contrast tested

ccocks avatar Jun 21 '24 21:06 ccocks

The view all button and the box header should both be black. My original code was contrast tested

Fair enough but the only reason I changed it then and there was because when I saw it it was:

Screenshot 2024-06-21 at 5 25 59 PM

MaterArc avatar Jun 21 '24 21:06 MaterArc

Thats weird

ccocks avatar Jun 21 '24 21:06 ccocks

Thats weird

No, you're right. I was just showcasing that the color it currently is should be darker (black) which you already noted as it's currently a shade of gray which looks off. So, just change the color to black and from a color standpoint it should be good 👍

MaterArc avatar Jun 21 '24 21:06 MaterArc

ok I see its gray.

ccocks avatar Jun 21 '24 21:06 ccocks

I had put color:black i dont see it anymore..

ccocks avatar Jun 21 '24 21:06 ccocks

Done! See line 19 & 16

ccocks avatar Jun 21 '24 21:06 ccocks

Screenshot 2024-06-21 at 5 32 27 PM

Yep, it's better now

MaterArc avatar Jun 21 '24 21:06 MaterArc

Is that done?

ccocks avatar Jun 21 '24 21:06 ccocks

I think this could work as an experimentational feature for now.

Would need others opinions

cally-jt avatar Jun 21 '24 21:06 cally-jt

Like I said, it needs work! But it's definitely a start...

MaterArc avatar Jun 21 '24 21:06 MaterArc

I'm back.

Like I said, it needs work! But it's definitely a start...

What work does it need? If you are talking about other Scratch pages, can't I just add them in future PR's?

ccocks avatar Jun 22 '24 00:06 ccocks

I'm back.

Like I said, it needs work! But it's definitely a start...

What work does it need? If you are talking about other Scratch pages, can't I just add them in future PR's?

I'm not sure about their exact thoughts for what it needs, but if there's further intended usage, then we don't want to ship any unfinished features.

rgantzos avatar Jun 22 '24 01:06 rgantzos

Ok I'll finish the home page styles by Monday.

ccocks avatar Jun 22 '24 15:06 ccocks

Ok. I finished the home page. Let me know if you have any suggestions. Also I can't test the whole thing at once. I test it commit by commit so if you can send me a screenshot of what it looks like that would be great 👍🏼

ccocks avatar Jun 22 '24 17:06 ccocks

Also, I was wondering how to use JavaScript in browser extensions. Is there anything different in browser extensions (especially for DOM manipulation)

ccocks avatar Jun 22 '24 20:06 ccocks

Ok. I finished the home page. Let me know if you have any suggestions. Also I can't test the whole thing at once. I test it commit by commit so if you can send me a screenshot of what it looks like that would be great 👍🏼 Screenshot 2024-06-22 at 5 38 02 PM

MaterArc avatar Jun 22 '24 21:06 MaterArc

The Scratch News white on light blue doesn't have a whole lot of contrast.

rgantzos avatar Jun 23 '24 20:06 rgantzos