SSASideMenu icon indicating copy to clipboard operation
SSASideMenu copied to clipboard

IPad pro (simulator) support

Open flandy84 opened this issue 10 years ago • 2 comments

new device, new problems :)

Please add iPadPro support for your menu. (Without blank areas between menu and content)

flandy84 avatar Nov 28 '15 14:11 flandy84

ok - small update

it seems to be the the same/older issue here --> #14

currently available "relative"-positioning-API of this slide-menu library forces developers to write device-size-dependent-code with magic-numbers, like this:

    if max(UIScreen.mainScreen().bounds.size.height, UIScreen.mainScreen().bounds.size.width) <= 1024{ //"regular" iPads and iPhones
        configure(SSASideMenu.ContentViewEffect(alpha: 1.0, scale: 1, landscapeOffsetX: -200, portraitOffsetX: -75))
    }else{  //"pro" iPads
        configure(SSASideMenu.ContentViewEffect(alpha: 1.0, scale: 1, landscapeOffsetX: -370, portraitOffsetX: -200))
    } 

please provide an update to your API with "fix"-menu-width-property . #14 ("I am very sorry this hasn't been done yet. I will try to get some time to do this in the upcoming week. ")

:)

thank you a lot for this great and simple library

flandy84 avatar Dec 03 '15 10:12 flandy84

A PR is very much appreciated. I currently don't have time to look at it.

SSA111 avatar Dec 07 '15 18:12 SSA111