Added some bindings for std::string_view when using c++17

Open kaptenhonek opened this issue 6 years ago • 8 comments

Title says it all :p

Sep 26 '19 08:09 kaptenhonek

Coverage remained the same at 100.0% when pulling 7465704cfc132140ad57d82fcc2ab9e8d7cc0477 on kaptenhonek:master into ffc1a3ef65400eb4d4c3db005092a1c3b68e7eb8 on SRombauts:master.

Sep 26 '19 08:09 coveralls

Hm, it seems I found some issues, don't pull this yet

Sep 26 '19 09:09 kaptenhonek

Ok, it should be working now

Sep 26 '19 09:09 kaptenhonek

Hello, would you perhaps be able to rebase / update this and fix the test coverage so I could merge it? Thanks!

Jan 13 '20 21:01 SRombauts

Sure, I'll fix it soon

Jan 14 '20 12:01 kaptenhonek

Ok this should be ready now. Due to me adding bind with const char* and length functions to bind text I had to change all binary blobs to unsigned char* so they will use the void* version.

Jan 21 '20 07:01 kaptenhonek

Just a quick update to let you know that I'll have to dive into this more seriously to see how this can be improved; I am pretty sure we should convert some of the bindXxx() overrides to templates like @KOLANICH did propose in it's pr #241 (commit a6eb4f48)

Jan 30 '20 20:01 SRombauts

Yeah, that seems like a wise idea

Feb 01 '20 14:02 kaptenhonek