pysipp icon indicating copy to clipboard operation
pysipp copied to clipboard

`pysipp.server()` accepts `destaddr` as a keyword argument

Open BVollmerhaus opened this issue 3 years ago • 1 comments

pysipp.server() and pysipp.client() appear to be implemented identically, the only exceptions being their respective default scenario name and the fact that pysipp.server() is not supposed to accept a destaddr keyword argument. However, the guard inside the function checks for dstaddr (without the "e"), which I'd assume to be a typo. Since server and client can be used interchangeably, I don't think this has functional implications, though.

BVollmerhaus avatar Jun 10 '22 13:06 BVollmerhaus

@BVollmerhaus please feel free to write a test or example showing your concern more explicitly.

Ideally provide a test demonstrating the typo causing an issue and then provide the fix.

goodboy avatar Dec 19 '22 16:12 goodboy