pysipp icon indicating copy to clipboard operation
pysipp copied to clipboard

Get random socket address

Open y-luis-rojo opened this issue 7 years ago • 6 comments

I tried to run tests in MacOS using osx_support branch (after merging master into it) and came out that test_stack:test_sync_run and test_stcak:test_async_run were failing because sipp command for UAC was triggered with 0.0.0.0 as server IP, so, I change to 127.0.0.1 when retrieving a random socket address with host=None.

I am not sure whether is related to MacOS but it did not fail when testing in Ubuntu Trusty.

y-luis-rojo avatar Oct 12 '18 16:10 y-luis-rojo

Related to #17

y-luis-rojo avatar Oct 12 '18 16:10 y-luis-rojo

I tried to run tests in MacOS using osx_support branch (after merging master into it)

@y-luis is it possible to try rebasing the history instead? Try from the osx branch git rebase upstream/master (or whatever you called the source repo).

goodboy avatar Oct 13 '18 01:10 goodboy

@y-luis just dropped pypy from CI in #52. Can you rebase this onto master and see how we do?

Also I think we can actually run CI against mac with the travis MacOS env. This might be worth putting in the effort now?

goodboy avatar Jul 04 '19 19:07 goodboy

Hmm looking at the CI results in detail it seems we've got bigger problems with this branch on linux for the py3 versions?

This seems odd. I wonder if moving to selectors will resolve some of this?

goodboy avatar Jul 04 '19 19:07 goodboy

Rebased from master. I have not had a lot of time to check it. Hope I can later.

y-luis-rojo avatar Jul 05 '19 13:07 y-luis-rojo

@y-luis thanks. I think we might have to delay this until we get py3 only support in because I don't want to have to fight with select stuff on py3 that's already been fixed/handled in the stdlib.

goodboy avatar Jul 05 '19 13:07 goodboy