andy icon indicating copy to clipboard operation
andy copied to clipboard

Removed comments + added line highlight at position of keyword

Open alexcojocaru2002 opened this issue 2 years ago • 3 comments

Closes #213

The aim of this Pull Request is to improve the SourceCodeSecurityCheckStep class.

  • [x] Change name of the class
  • [x] Remove comments when checking code
  • [x] When having an error highlight the corresponding line and not line 1.

alexcojocaru2002 avatar Sep 19 '23 21:09 alexcojocaru2002

@martinmladenov How should I rename the class ? Also should I write a separate test for removeComments method ?

alexcojocaru2002 avatar Sep 19 '23 21:09 alexcojocaru2002

@alexcojocaru2002

@martinmladenov How should I rename the class ? Also should I write a separate test for removeComments method ?

Good question, I haven't thought about that. Maybe something like "SourceCodeCheckStep" would be suitable (but this could be misleading as people might think it has to do with code checks). If you think of anything more suitable, feel free to use that instead. @mauricioaniche Do you have any ideas?

martinmladenov avatar Sep 20 '23 14:09 martinmladenov

SourceCodeCheckStep looks good to me!

mauricioaniche avatar Sep 20 '23 14:09 mauricioaniche