scons icon indicating copy to clipboard operation
scons copied to clipboard

[WIP] Prioritize nodes with more waiting parents when adding new candidates

Open acmorrow opened this issue 3 years ago • 4 comments

Contributor Checklist:

  • [ ] I have created a new test or updated the unit tests to cover the new/changed functionality.
  • [x] I have updated CHANGES.txt (and read the README.rst)
  • [x] I have updated the appropriate documentation

acmorrow avatar May 20 '22 18:05 acmorrow

Let's hang back on merging this. I do think there is something to be done along these lines, but I 1) agree that this is at best a partial implementation because it doesn't globally prioritize, and 2) I haven't been able to demonstrate the increased build throughput that I hoped it would provide.

acmorrow avatar Oct 24 '22 12:10 acmorrow

I've added a WIP to the title to that end

mwichmann avatar Oct 24 '22 19:10 mwichmann

@acmorrow - is this PR still valid/useful/ updatable with other changes already merged?

bdbaddog avatar May 19 '24 01:05 bdbaddog

I still think there is something to this idea, since, given the option, it always seems better to act on nodes with lots of waiting parents preferentially, but without a meaningful performance testing environment for SCons it is hard to show whether it actually improves throughput.

acmorrow avatar May 19 '24 13:05 acmorrow