ShapeWorks icon indicating copy to clipboard operation
ShapeWorks copied to clipboard

C++: Remove Templating from Libs/Optimize

Open HeavenlyBerserker opened this issue 5 years ago • 4 comments

Templating is not used, so it should be removed to facilitate new functions and classes. Alan: Trying to change anything causes issues for other people who work on Libs/Optimize when merging.

(long term goal)

HeavenlyBerserker avatar Oct 01 '20 20:10 HeavenlyBerserker

@akenmorris @HeavenlyBerserker Is this planned for the next release?

sheryjoe avatar Feb 15 '21 17:02 sheryjoe

No, it's a long term goal. We're part way there. I wouldn't tie it to any release as it does not affect users or the computation. It will speed development when done though.

akenmorris avatar Feb 16 '21 16:02 akenmorris

Getting there. Have removed lots of the useless templates.

akenmorris avatar Jul 21 '23 18:07 akenmorris

Remaining templates are in

  • [ ] Container/GenericContainer and inherited classes
  • [ ] Domain/ImageDomain and inherited classes
  • [ ] Domain/VtkMeshWrapper
  • [ ] Neighborhood/PowerOfTwoPointTree
  • [ ] Utils/ObjectReader and Writer
  • [ ] Utils/ParticleGaussianModeWriter

Not all of them need to have templates removed, I think. I'm looking into Domain/VtkMeshWrapper through issue #1408.

HeavenlyBerserker avatar Jul 31 '23 18:07 HeavenlyBerserker