ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard
verified publisher icon SAP

chore(ui5-table): remove selection import & rename key

Open DonkeyCo opened this issue 1 year ago • 2 comments

Table.ts imported TableSelection.ts, although it is not a base functionality. Therefore, the selection has been removed as import and the code has been refactored to accomodate for that.

Additionaly, key is a reserved keyword in React, which is why the row key has been renamed to row-id.

DonkeyCo avatar Jun 25 '24 13:06 DonkeyCo

@aborjinik if you could review this PR, it would be great

DonkeyCo avatar Jul 02 '24 18:07 DonkeyCo

@ilhan007: @aborjinik is unavailable today (d-com), if we need to merge today, I'd need a +2 from you. We had a private discussion already and the current state is good to be merged

DonkeyCo avatar Jul 03 '24 08:07 DonkeyCo

Please see the comments you can align the docu later

Will do this tomorrow

DonkeyCo avatar Jul 04 '24 20:07 DonkeyCo