ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard

[DynamicPage (v2.0.0-rc.6)]: outline recommended `font-size` of `heading` in docs

Open Lukas742 opened this issue 1 year ago • 2 comments

At the moment I don't think it's described clearly enough how to adjust the font-size of the heading to the recommended values. The relevant CSS variables can be found in the code examples, but it's probably worth mentioning them more clearly in the docs. E.g. in the description of the heading slot.

CSS Vars:

  • expanded: 'var(--sapObjectHeader_Title_FontSize)'
  • collapsed: 'var(--sapObjectHeader_Title_SnappedFontSize)'

Lukas742 avatar Jun 19 '24 09:06 Lukas742

Hey colleagues,

@SAP/ui5-webcomponents-topic-p, could you please take a look at this recommendation from our colleague, about enhancing the documentation of our DynamicPage component ?

Kind Regards, Stoyan

hinzzx avatar Jun 19 '24 12:06 hinzzx

Internal Reference: BGSOFUIPIRIN-6587

dobrinyonkov avatar Jun 20 '24 06:06 dobrinyonkov

Hi, I've noticed that the information is now exposed in the documentation: https://sap.github.io/ui5-webcomponents/components/fiori/DynamicPageTitle/#heading

So, this issue can probably be closed, right?

Lukas742 avatar Aug 09 '24 06:08 Lukas742

Hi @Lukas742 , that's correct, thanks for reminding!

dobrinyonkov avatar Aug 09 '24 06:08 dobrinyonkov