ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard

DRAFT: refactor(ui5-li): wrap by default

Open yanaminkova opened this issue 1 year ago • 5 comments

The text of ui5-li now wraps by default. Also, the wrappingType property of ui5-li is now public.

Related to https://github.com/SAP/ui5-webcomponents/issues/8461, https://github.com/SAP/ui5-webcomponents/issues/7887

yanaminkova avatar Jun 11 '24 10:06 yanaminkova

This is considered breaking change so let's add it to the commit message body.

dobrinyonkov avatar Jun 14 '24 08:06 dobrinyonkov

Hello @SAP/ui5-webcomponents-topic-rd, could you please check this PR in terms of NoticationList updates? Thanks!

dobrinyonkov avatar Jun 14 '24 08:06 dobrinyonkov

The fixed 5rem height of the ListItem, is blocking/cutting the title text (perhaps the description and additionalText too). You can test this by adding wrapping-type="Normal" to a the first list item in the List.html file. This way the wrapping styles are applied.

BTW, shouldn't the text wrap even without setting that attribute? Perphaps we should review this once again with design team, once the above issue is resolved.

dobrinyonkov avatar Jun 14 '24 09:06 dobrinyonkov

There is a richer design spefication about the wrapping of the list items that needs to be implemented. The property wrappingType of the ui5-li is currently private so this change would not be a breaking one. The work on this will continue in the coming sprints.

dobrinyonkov avatar Jun 27 '24 07:06 dobrinyonkov

Also, don't forget to remove the BREAKING CHANGE section, If we keep it and merge it after 2.0 - it would trigger the release of new major.

ilhan007 avatar Jun 30 '24 17:06 ilhan007