ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard

Additional reading for elements used in Dialog Footer

Open C5362575 opened this issue 1 year ago • 5 comments

Bug Description

When accessing the elements in footer of the Dialog for example a button, the information is being read out as "Header Toolbar" which is incorrect. As here the element is added in the Footer. This reading is being done by screen readers like Screen Reader: JAWS Version 2024.2312.53

Affected Component

Dialog

Expected Behaviour

When the UI element is accessed from Footer of Dialog using screen readers, then correct information must be communicated to the user. For our scenario elements present in the Footer should read under "Footer toolbar" section and not "Header toolbar"

Isolated Example

No response

Steps to Reproduce

Navigate to the Footer section of Dialog while the screen reader is reading the content only relevant information about the UI should be communicated to the user. Additional information should be avoided.

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.19.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • [X] I’m not disclosing any internal or sensitive information.

C5362575 avatar May 07 '24 06:05 C5362575

Hello @C5362575,

Could you please provide a link to an isolated example if possible by forking this stackblitz?

I checked the samples in our playground and I was not able to reproduce the issue: https://sap.github.io/ui5-webcomponents/components/Dialog/

Thank you in advance!

Kind Regards, Niya

niyap avatar May 07 '24 08:05 niyap

Hi @niyap Please find forked modified (https://stackblitz.com/edit/js-rdhenh?file=index.html) Dialog component which has a footer as well . When the UI element is accessed from the Footer of Dialog using screen readers, then correct information must be communicated to the user. For our scenario elements present in the Footer should read under "Footer toolbar" section and not "Header toolbar"

@niyap can you also confirm which screen reader are you using for testing purpose

C5362575 avatar May 10 '24 04:05 C5362575

Hello @C5362575,

I have retested with the fork you provided and there is no mention of "Header toolbar". Jaws version 2024.2312.53

Please refer to the attached screenshot which is showing speech output of the screen reader. Screenshot 2024-05-15 at 13 49 40

Can you provide more guidance on how to reproduce it?

Best Regards, Gergana

GerganaKremenska avatar May 15 '24 11:05 GerganaKremenska

Hi @GerganaKremenska there is a version mismatch, we have "@ui5/webcomponents": "1.17.0" in our app but in code sandbox we have "@ui5/webcomponents": "1.20.1"

can you please change the version in code sandbox and test it again

C5362575 avatar May 17 '24 04:05 C5362575

Hello @C5362575 ,

I have retested with "@ui5/webcomponents": "1.17.0" - stackblitz

Here is the result and stil i do not see the issue. Screenshot 2024-05-17 at 8 12 50

Please provide your speech history. Or more information on how to reproduce the issue.

Best Regards, Gergana

GerganaKremenska avatar May 17 '24 05:05 GerganaKremenska

Hello, everyone! The issue has been inactive for 21 days. If there are still questions or comments, please feel free to continue the discussion. Inactive issues will be closed after 7 days!

github-actions[bot] avatar Jun 08 '24 00:06 github-actions[bot]

Hello, everyone! The issue has been inactive for 28 days, so I am closing the issue.

github-actions[bot] avatar Jun 16 '24 00:06 github-actions[bot]