ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard

[Feature Request]: Fiori PDF Viewer

Open wvudako opened this issue 2 years ago • 2 comments

Feature Request Description

Fiori defines a PDF Viewer https://experience.sap.com/fiori-design-web/pdf-viewer/ which is also implemented in the reference implementation https://ui5.sap.com//#/entity/sap.m.PDFViewer

We would like to use this component in UI5 React as we had to implement quite some styling hacks to use an IFrame in an object page

Proposed Solution

Implement as per Fiori Spec

Proposed Alternatives

No response

Organization

No response

Additional Context

No response

Priority

Medium

Privacy Policy

  • [X] I’m not disclosing any internal or sensitive information.

wvudako avatar Oct 31 '23 08:10 wvudako

Hello @SAP/ui5-webcomponents-topic-core, take a look of this feature request.

TeodorTaushanov avatar Oct 31 '23 09:10 TeodorTaushanov

Hi @gitgdako,

Could you please share what kind of hacks you had to use and what problems you've faced?

I prepared a snippix and doesn't look hard to be achieved. https://codesandbox.io/s/interesting-sun-46tkkz?file=/src/App.js

We would like to hear your what problems you've faces so we can determine how to with the processing of the issue.

Thanks in advance!

nnaydenow avatar Jan 05 '24 13:01 nnaydenow

Hello, everyone! The issue has been inactive for 21 days. If there are still questions or comments, please feel free to continue the discussion. Inactive issues will be closed after 7 days!

github-actions[bot] avatar Jul 17 '24 00:07 github-actions[bot]

Hi. We are rendering an IFrame with position: 'absolute', top: '0', left: '0', width: '99%', height: '99%',

wrapped in a div with height: '100%', overflow: 'hidden', position: 'relative'"

The ObjectPage itself is wrapped in a div with height: 'calc(100vh - var(--fdShellbar_Height))'

I am sure that this is the sum of things we needed to do to have the pdf viewer of the browser render all the way to the bottom without having a second scrollbar, which, as you can see, was a bit tricky to achieve

wvudako avatar Jul 17 '24 07:07 wvudako

Hello @wvudako, there isn't significant demand and we have decided long time ago, sorry for not updating you timely here in the issue, not to invest in creating and supporting such web component.

Unfortunately, we have to reject this one. We rarely reject requests, but some requests don't fit at all in our plans and strategy. When it comes to extending the component set, we carefully consider the value and the demand before developing a new web component. And in this case, as of now, we don't see great value and demand.

ilhan007 avatar Apr 04 '25 15:04 ilhan007