ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard

Inputs do not have margin with Horizon theme

Open allen138 opened this issue 3 years ago • 0 comments

Bug Description

Hi team, When using the Horizon theme, there should be a margin: 0.25rem 0 on the inputs. This applies for any inputs. When the webcomponent is placed next to either SAPUI5 sap.m.Input or a native input using fundamental styles which do correctly have this margin, this creates a misalignment. Please see: image

Expected Behavior

When horizon theme is implemented, inputs should have a margin: 0.25rem 0.

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/Input/?sap-ui-theme=sap_horizon&isrtl=false
  2. Inspect the inputs and verify there is no margin.
  3. Go to https://openui5.hana.ondemand.com/entity/sap.m.Input/sample/sap.m.sample.InputTypes?sap-ui-theme=sap_horizon&isrtl=false
  4. Inspect the inputs and see there is a margin: 0.25rem 0
  5. Go to https://sap.github.io/fundamental-styles/?path=/docs/components-forms-input--primary&globals=theme:sap_horizon
  6. Inspect the inputs and see there is a margin: 0.25rem 0

Context

  • UI5 Web Components version: main
  • OS/Platform: All
  • Browser: All
  • Affected component: Inputs

Priority

  • [ ] Low
  • [x] Medium
  • [ ] High
  • [ ] Very High

Stakeholder Info (if applicable)

  • Organization: SF
  • Business impact: Medium

allen138 avatar Oct 14 '22 17:10 allen138