ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard
verified publisher icon SAP

Breadcrumbs: A11y Issue - The role of current page text should be 'text'

Open sleric1024 opened this issue 3 years ago • 4 comments

Describe the bug When reading "current page" (Notebooks) its announced as a "link" while its not a link but just plain text

Isolated Example https://codesandbox.io/s/competent-smoke-mqee3x?file=/src/App.js

To Reproduce Steps to reproduce the behavior:

  1. Go to https://mqee3x.csb.app/
  2. Inspect with Chrome developer tool
  3. Check the text Notebooks
  4. The role is marked as 'link' but it's just a plain text

Expected behavior The role should be text

Screenshots image

UI5 Web Components for React Information @ui5/webcomponents version: 1.6.0 @ui5/webcomponents-react version: 0.27.0 Operating System: MacOS Browser: Chrome

Additional context I am from SAP Successfactors, and this issue is reported from SF a11y expert.

sleric1024 avatar Aug 25 '22 01:08 sleric1024

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

Lukas742 avatar Aug 25 '22 07:08 Lukas742

Hi colleagues from @SAP/ui5-webcomponents-topic-p , can you, please, check if the current location element intentionally has the role of a link? Thank you!

Best regards, Petya Markova. (UI5 WC Dispatcher)

PetyaMarkovaBogdanova avatar Aug 26 '22 13:08 PetyaMarkovaBogdanova

Hi @sleric1024 ,

ui5-breadcrumbs is navigation with set of links. By W3C best practices last link should be marked as link even if it is only text. The best practices are analysed by our accessibility experts and seems that the component is implemented by their spec.

@dobrinyonkov

Regards, Nayden

nnaydenow avatar Aug 31 '22 10:08 nnaydenow

@nnaydenow Please see W3C example of breadcrumbs. https://www.w3.org/WAI/ARIA/apg/example-index/breadcrumb/index.html image Their "current page" is a "link" which has a "href" that seems to link back to same page. However your implementation has role of link with no href thus contradicting the role provided while it appears and functions as plain text.

anuvenkatesh1 avatar Sep 14 '22 02:09 anuvenkatesh1

Specification update in progress. It involves work from our IXD team. An item is created on their board and work is planned to start with the next development takt.

dobrinyonkov avatar Oct 19 '22 18:10 dobrinyonkov

I am setting this one to blocked until we have the UX design

nikolay-kolarov avatar Oct 31 '22 12:10 nikolay-kolarov

Specification update is done. Item is moved to our plannig queue to be implemented in the coming sprints. Progress will be shared in this issue.

dobrinyonkov avatar Apr 20 '23 12:04 dobrinyonkov

Internal Reference: FIORIDESIGN-7374, BGSOFUIPIRIN-6419

dobrinyonkov avatar Jan 12 '24 12:01 dobrinyonkov

Closed by https://github.com/SAP/ui5-webcomponents/pull/8206

dobrinyonkov avatar Feb 06 '24 19:02 dobrinyonkov