[SF][ui5-toolbar]: consider element scoping in toolbar shared resources

[zhangliangyi]

Bug Description

I noticed that there is a shared resource registry in the new ui5-toolbar component. But right now, the pure tag name is used as the registry key. https://github.com/SAP/ui5-webcomponents/blob/19475eb897d08c5f09ae2583678cc79decca5adc/packages/main/src/ToolbarRegistry.ts#L8

But considering the element scoping, if there are several ui5 contexts in the current runtime, the toolbar constructor would be polluted. All the toolbar components would use the first registered constructor even they have element scope defined for different versions.

Affected Component

ui5-toolbar

Expected Behaviour

Using tag name with element scoping as the registry key.

Isolated Example

No response

Steps to Reproduce

N/A

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

2.3.0

Browser

Edge

Operating System

No response

Additional Context

No response

Organization

SF

Declaration

• [X] I’m not disclosing any internal or sensitive information.

[PetyaMarkovaBogdanova]

Hi team, can you, please, review this enhancement request? Best regards, Petya Markova. (UI5 Web Components Dispatcher)

[zhangliangyi]

This issue is a solid blocker when leveraging new toolbar component in our upgrade work. As a workaround, right now we have to roll back to the legacy toolbar in ui5-react.

[PetyaMarkovaBogdanova]

Hi @zhangliangyi I would like to inform you, that we opened a backlog item (BGSOFUIPIRIN-6755) for implementation of the desired functionality in ui5-toolbar. Any progress will be updated here. Best regards, Petya Markova. UI5 Web Components Developer

[dobrinyonkov]

Hello @zhangliangyi,

the toolbar now renders items physically and the registry was deleted - https://github.com/SAP/ui5-webcomponents/issues/10622

This issue should be resolved.

Regards, Dobrin

[github-actions[bot]]

This issue has been closed. To reopen, just leave a comment!