ui5-webcomponents-react icon indicating copy to clipboard operation
ui5-webcomponents-react copied to clipboard

[SF][A11y][0.26.0][MessageBox]modal dialog announcement of MessageBox is missing

Open ksblklu opened this issue 3 years ago • 9 comments

Describe the bug Modal dialog announcement is missing after opening MessageBox Component

To Reproduce Steps to reproduce the behavior:

  1. Go to MessageBox Document Page
  2. Click on 'open MessageBox' button
  3. Inspect speech history of JAWS screen reader
  4. See announcement of MessageBox modal dialog is missing
image

Expected behavior Modal dialog message should be announced after the MessageBox opens, same as dialog: image

UI5 Web Components for React Information @ui5/webcomponents version: 1.5.0 @ui5/webcomponents-react version: 0.26.0 Operating System: Windows Browser: Chrome

ksblklu avatar Jul 06 '22 08:07 ksblklu

Hey colleagues,

it looks like the ui5-dialog is not announced as modal when using the header slot:

<ui5-dialog open header-text="Hello World">Content</ui5-dialog>

This is announced as modal.

When using a header slot, JAWS is not announcing the ui5-dialog as modal:

<ui5-dialog open><header slot="header">Hello World</header>Content</ui5-dialog>

MarcusNotheis avatar Aug 02 '22 09:08 MarcusNotheis

Hello @SAP/ui5-webcomponents-topic-rd could you please have a look?

ilhan007 avatar Aug 02 '22 09:08 ilhan007

Hello @MarcusNotheis,

I isolate the samples you provided and the both cases the Jaws 2022 announces "modal" when the dialog opens. https://codesandbox.io/s/ui5-webcomponents-forked-2l0pu6?file=/index.html I see no issue here.

Note that for the second case (with the slot) in the documentation there is "Note: If header slot is provided, the labelling of the dialog is a responsibility of the application developer. accessibleName should be used."

Best Regards, Lidiya

LidiyaGeorgieva avatar Aug 15 '22 14:08 LidiyaGeorgieva

@MarcusNotheis , When will this fix be released? We need to consume it by Sept. 15th.

don-obrien avatar Sep 07 '22 14:09 don-obrien

We're currently blocked by https://github.com/SAP/ui5-webcomponents/issues/5778, so this is unfortunately out of our hands. As soon as there is a 1.7.1 version available, we'll release our new version.

MarcusNotheis avatar Sep 07 '22 14:09 MarcusNotheis

:tada: This issue has been resolved in version v0.28.0 :tada:

The release is available on v0.28.0

Your semantic-release bot :package::rocket:

Hi @MarcusNotheis , this issue still exist in 0.28.1, would you please have a look? image

ksblklu avatar Sep 15 '22 02:09 ksblklu

Hey @ksblklu, does this issue only occur for the MessageBoxType Confirm? Or for other types like Success, Error, etc. as well?

MarcusNotheis avatar Sep 29 '22 08:09 MarcusNotheis

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Inactive issues will be closed after 7 days. Thanks.

github-actions[bot] avatar Oct 14 '22 02:10 github-actions[bot]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Inactive issues will be closed after 7 days. Thanks.

github-actions[bot] avatar Nov 02 '22 02:11 github-actions[bot]

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one.

github-actions[bot] avatar Nov 10 '22 02:11 github-actions[bot]

hi @MarcusNotheis , I've tested Messagebox with all MessageBoxTypes, and none of it made correct announcement "Modal dialog" after opening. Please kindly reopen this issue and take a look, thanks.

ksblklu avatar Nov 22 '22 08:11 ksblklu

@MarcusNotheis , can you remove the author action label, if you are satisfied with the response?

don-obrien avatar Nov 28 '22 19:11 don-obrien

Issue is blocked by https://github.com/SAP/ui5-webcomponents/issues/5796

MarcusNotheis avatar Dec 15 '22 11:12 MarcusNotheis

Hi @MarcusNotheis The blocking issue https://github.com/SAP/ui5-webcomponents/issues/5796 seems fixed, can we continue on processing this issue?

ksblklu avatar Mar 22 '23 03:03 ksblklu

Yes, we'll now starting working on it again

MarcusNotheis avatar Mar 22 '23 13:03 MarcusNotheis

:tada: This issue has been resolved in version v1.12.0 :tada:

The release is available on v1.12.0

Your semantic-release bot :package::rocket: