ui5-webcomponents-react icon indicating copy to clipboard operation
ui5-webcomponents-react copied to clipboard

VariantManagement: Manage Views Is Not Getting Translated When Changing To A Different Language

Open nidhi0104 opened this issue 3 years ago • 4 comments

In variant management, the manage views text is not getting translated when changing to different language.

Check this link : https://sap.github.io/ui5-webcomponents-react/?path=/story/inputs-variantmanagement--default-story&sap-language=de

Steps to reproduce the behavior:

  1. Go to Variant Management
  2. Click on Manage Button
  3. See error

The text 'Manage Views' should be translated to German on keeping the language=de

UI5 Web Components for React Information @ui5/webcomponents version: ~1.4.0 @ui5/webcomponents-react version:0.25.7 Operating System: Browser:Chrome

nidhi0104 avatar Aug 23 '22 05:08 nidhi0104

Hi @nidhi0104

the url param you used is incorrect. Please try with sap-ui-language=de as described in our documentation. https://sap.github.io/ui5-webcomponents-react/?path=/story/inputs-variantmanagement--default-story&sap-ui-language=de

Lukas742 avatar Aug 23 '22 06:08 Lukas742

I tried with the given link also, but the text translation is not correct.

nidhi0104 avatar Aug 23 '22 07:08 nidhi0104

My mistake, I thought you were referring to the button text. You are correct that the heading of the Dialog should also be translated.

Lukas742 avatar Aug 23 '22 08:08 Lukas742

Keeping this issue open until the translations are available.

Lukas742 avatar Aug 23 '22 14:08 Lukas742

~~:tada: This issue has been resolved in version v0.27.4 :tada:~~

~~The release is available on v0.27.4~~ --> Still waiting for translations.

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version v0.27.5 :tada:

The release is available on v0.27.5

Lukas742 avatar Sep 02 '22 13:09 Lukas742