ui5-webcomponents-react icon indicating copy to clipboard operation
ui5-webcomponents-react copied to clipboard

[SF][A11y][0.26.1][DynamicPageTitle] Screen reader issues of actions overflow menu button

Open ksblklu opened this issue 3 years ago • 1 comments

Describe the bug When user opens the actions overflow ellipsis button menu of DynamicPageTitle

  1. observe when opened, there is no indication of opening
  2. as we navigate through the options, the item count is also missing

To Reproduce Steps to reproduce the behavior: Environment: Windows, Chrome, JAWS 2022

  1. Go to https://sap.github.io/ui5-webcomponents-react/?path=/docs/layouts-floorplans-dynamicpage--default-story
  2. Click on actions overflow button of DynamicPageTitle
  3. Tab navigating through the popup menu items
  4. Inspect the JAWS speech history, theres no indication of overflow popup menu, and item count of menu items is also missing image

Expected behavior Refer to WCAG actions menu button: image

UI5 Web Components for React Information @ui5/webcomponents version: 0.26.1 @ui5/webcomponents-react version: 1.5.0 Operating System: Windows Browser: Chrome

ksblklu avatar Jul 12 '22 07:07 ksblklu

What is the plan on fixing this issue? Priority of medium is ok. In agreement with Stoehr.

jatinthaker avatar Aug 23 '22 20:08 jatinthaker

Hi @ksblklu

I compared our implementation with the one of SAPUI5 and our announcements are not 100% equal, but similar enough in my opinion. E.g. with SAPUI5 there is also no item count and if the popover is open there is an "dialog" announcement with NVDA, but none with JAWS (which seems faulty to me, since the role is set to dialog).

Since we are following the UI5 implementation, I think our current implementation is correct.

If you want to change the aria announcements you can probably do that by leveraging the actionsToolbarProps or navigationActionsToolbarProps props of the DynamicPageTitle component. There you can pass all allowed props of the Toolbar component.

Lukas742 avatar Aug 26 '22 15:08 Lukas742

Hi @Lukas742 Thanks for the information! For the item count announcement of buttons inside Toolbar, onOverflowChange method could solve this issue. But in SAPUI5 Toolbar example, we saw there is an item count announcement implemented in Toolbar component overflow menu. Can we align our Toolbar component to UI5 Toolbar? image

ksblklu avatar Aug 30 '22 06:08 ksblklu

Hi @ksblklu

The SAPUI5 Toolbar component has no overflow capabilities, so the item announcement is coming from the custom implemented ActionSheet (see implementation details) and not the Toolbar itself. We based our toolbar on the SAPUI5 OverflowToolbar

Lukas742 avatar Aug 30 '22 08:08 Lukas742

Hi @Lukas742 Thanks for the details, I'll use the actionsToolbarProps to customize the aria announcement of DynamicPageTitle actions toolbar.

ksblklu avatar Aug 30 '22 10:08 ksblklu