ui5-webcomponents-react icon indicating copy to clipboard operation
ui5-webcomponents-react copied to clipboard

Variant Management: missing accessibility props

Open sparkypro opened this issue 3 years ago • 3 comments

Describe the bug Accessible name properties missing for VariantManagement UI component

UI Link Refer: https://sap.github.io/ui5-webcomponents-react/?path=/docs/inputs-variantmanagement--default-story

Missing Accessible name property is missing for VariantManagment UI, component.

Expected behavior Accessible name property must be available. Also provide accessible reading for selected value if any. This property enables the accessibility options for screen readers.

UI5 Web Components for React Information @ui5/webcomponents version: 1.4.0 @ui5/webcomponents-react version: 0.25.6 Operating System: Windows 11 Browser: Chrome

sparkypro avatar Jun 24 '22 07:06 sparkypro

Hi @sparkypro

I don't see why we would need an accessibleName prop here. Could you elaborate more on why you think this is necessary.

Lukas742 avatar Jun 27 '22 07:06 Lukas742

On screen reader like JAWS, the dropdown arrow applicable shall read 'Select View' twice. This is because, inside 'VariateManagement' component, there is a ui5 button (which is a dropdown arrow) which has property set as 'Select View' for both title & aria-label. Both has same value, which is internally applied, and have no control to developer to change the aria-label. Because of this the screen-reader picks up both title & aria-label which is read to user which is confusing.

sparkypro avatar Jun 27 '22 07:06 sparkypro

Also additionally a tooltip is also required as part of the dropdown select view. As I see https://sap.github.io/ui5-webcomponents-react/?path=/docs/inputs-variantmanagement--default-story the dropdown arrow or the component don't have tooltip property.

sparkypro avatar Jul 13 '22 09:07 sparkypro

Hi @sparkypro

when the linked PR is merged and released a tooltip will now be displayed when hovering the dropdown button, and the aria-label will be added to the right place inside the shadow root. If JAWS still reads both the title and the aria-label, then this should be the intended behavior, as we need both attributes here for accessibility reason. Since this behavior should not be changed, we won't offer a way to customize it.

Lukas742 avatar Nov 08 '22 12:11 Lukas742

:tada: This issue has been resolved in version v1.4.0 :tada:

The release is available on v1.4.0

Your semantic-release bot :package::rocket: