ui5-tooling icon indicating copy to clipboard operation
ui5-tooling copied to clipboard

New builder setting to fix data source URI in manifest.json

Open budenko opened this issue 3 years ago • 9 comments

Is your feature request related to a problem? Please describe.

Data source URI in manifest.json should not start with a slash in order to UI5 application work properly in a FLP.

Describe the solution you'd like

It would be nice to have a builder task or setting that checks manifest.json and strips off leading slash from a data source URI during a building of an application to ensure that URI is correct automatically.

Describe alternatives you've considered

There is a such feature in @sap/grunt-sapui5-bestpractice-build module that is not supported any more and should be replaced with @ui5/builder.

Additional context

Example of a data source section of manifest.json

  "dataSources": {
    "Document-RestSource": {
      "uri": "fnd/document-ms/",
      "type": "JSON"
    }
  }

budenko avatar Jun 04 '22 15:06 budenko

It would be great to have this feature directly in ui5-tooling. At the moment the Fiori Application Generator uses a custom task using "webide-extension-task-updateManifestJson" to update the manifest.json when deploying to Cloud Foundry.

https://www.npmjs.com/package/@sap/ui5-builder-webide-extension is quite old and has a dependency to @ui5/[email protected] and @ui5/[email protected].

sebastianesch avatar Oct 06 '23 13:10 sebastianesch

Absolutely agree with previous post, current 'deploy-config' script generates quite an outdated and huge list of dependencies.

Regloom avatar Apr 04 '24 13:04 Regloom

As far as I remember, SAP Build Work Zone, standard edition a.k.a "Central Launchpad on CF" does not support absolute URLs at all. So the url should be relative in the source manifest.json.

I wonder why you not adjust the source manifest.json to make it relative right from the beginning?

flovogt avatar Apr 04 '24 14:04 flovogt