ui5-tooling icon indicating copy to clipboard operation
ui5-tooling copied to clipboard

Putting index.html in sap-ui-cachebuster-info.json file

Open whydrae opened this issue 4 years ago • 1 comments

Expected Behavior

index.html shouldn't be in the sap-ui-cachebuster-info.json file (?)

Current Behavior

index.html is in the sap-ui-cachebuster-info.json file.

Steps to Reproduce the Issue

There's an issue I initially created in the OpenUI5 repository: https://github.com/SAP/openui5/issues/3158.

As I noticed, the issue is happening because index.html file gets into the cache buster file.

I'm running app in neo landscape and added the following directive into neo-app.json file, but it seems like this file is not processed during the ui5 tooling build.

	"cacheControl": [{
		"directive": "private",
		"maxAge": 0,
		"path": "**.html"
	}

Should index.html be in the cache index at all? Is there a way to exclude this file?

Thanks!

Context

"@ui5/cli": "^1.14.0", "@sap/ui5-builder-webide-extension": "^1.0.9"

whydrae avatar Feb 17 '21 05:02 whydrae

Thank you for reporting this issue. Sounds like we should introduce an excludes configuration for the cachebuster task, maybe defaulting to a top-level "index.html".

Since the cachebuster in NW ABAP currently behaves the same way as the UI5 Tooling (both include index.html), we'll treat this as an enhancement rather than a bug.

RandomByte avatar Feb 22 '21 12:02 RandomByte