ui5-tooling
ui5-tooling copied to clipboard
Dependency bundling ignores mvc factory functions
Expected Behavior
MVC factory APIs like sap.ui.fragment should be identified as dependency declarations.
Current Behavior
Resources referenced by MVC factories are not processed as bundle dependencies.
Steps to reproduce the issue
- Setup openui5-sample-app
- Add
sap.ui.layoutdependency for technical information dialog:npm install @openui5/sap.ui.layout - Execute
ui5 build self-contained --all - Serve
distdirectory - Open technical information dialog by pressing CTRL + SHIFT + ALT + P
- Observe in the network trace that single sap.ui.layout controls are being loaded.
➡️ This indicates that they are not part of the self contained bundle
Related code: https://github.com/SAP/openui5/blob/9974c1e7f9179397745d896df72cf2d1d773f325/src/sap.ui.core/src/sap/ui/core/support/techinfo/TechnicalInfo.js#L79
CC: @codeworrior
Also see https://github.com/SAP/ui5-tooling/issues/68
Affected components
- [x] ui5-builder
- [ ] ui5-server
- [ ] ui5-cli
- [ ] ui5-fs
- [ ] ui5-project
- [ ] ui5-logger
Still reproducible also with UI5 Tooling V3