ui5-tooling icon indicating copy to clipboard operation
ui5-tooling copied to clipboard

Dependency test-resources should be omitted in build

Open BenReim opened this issue 7 years ago • 8 comments

Expected Behavior

test-resources of project dependencies shall not be part of a (production) build

Current Behavior

test-resources folder is part of the build result

Steps to reproduce the issue

  1. Clone ui5lab sample library git clone https://github.com/UI5Lab/UI5Lab-library-simple

  2. Build library ui5 build --a

  3. Check the content of the dist folder - contains test-resources of dependencies

UI5Lab-app-simple (master)
$ ls -1 ./dist
Component.js
Component-dbg.js
Component-preload.js
controller/
css/
i18n/
index.html
indexSelfContained.html
manifest.json
model/
resources/
test/
test-resources/ <---- test resources of ui5lab-library dependency
view/

BenReim avatar Nov 27 '18 09:11 BenReim

I think this is more of an enhancement, but definitely something we should look into.

Currently, test-resources might be required when one libraries tests depend on test specific helper modules located in another libraries test-resources. This means we'll probably need a switch of some sort. Possibly something like:

Command Result
ui5 build --all Everything (current behavior)
ui5 build --runtime Like --all but excluding test-resources

RandomByte avatar Feb 04 '19 17:02 RandomByte