ui5-tooling icon indicating copy to clipboard operation
ui5-tooling copied to clipboard

sap-ui-version.json should contain a UI5 version

Open codeworrior opened this issue 5 years ago • 1 comments

Expected Behavior

UI5's own support assistant needs to determine the UI5 version to be able to activate version dependant support rules. It currently uses the main version from the sap-ui-version.json. This is fine for CDN or other shared installations where the main version is the UI5 version. But for standalone apps, the main version is the version of the app itself.

Using the version of sap.ui.core could be a workaround, but it might differ from the UI5 version in the patch level (in the case of SAPUI5, not OpenUI5).

It would therefore be beneficial, if the framework version would be contained in the sap-ui-version.json as well (maybe together with the name of the framework, OpenUI5 or SAPUI5).

Steps to reproduce the issue

  1. Build a standalone app (with e.g. version 1.2.3 and using UI5 framework 1.71 or higher)
  2. Check the main version in the generated sap-ui-version.json

Other Information

Also see https://github.com/SAP/openui5/issues/2892 .

codeworrior avatar Jun 10 '20 16:06 codeworrior

executed:

yo easy-ui5 
ui5 build --config=uimodule/ui5.yaml self-contained

ui5.yaml

specVersion: "2.2"
metadata:
  name: myUI5App_uimodule
type: application
framework:
  name: OpenUI5
  version: 1.80.0
  libraries:
    - name: sap.ui.core
    - name: sap.m
    - name: sap.ui.layout
    - name: themelib_sap_fiori_3
...

package.json

{
  "name": "myUI5App",
  "version": "0.0.1",
...

sap-ui-version.json

{
	"name": "myUI5App_uimodule",
	"version": "0.0.1",
	"buildTimestamp": "202009221454",
	"scmRevision": "",
	"libraries": [
		{
			"name": "sap.m",
			"version": "1.80.0",
			"buildTimestamp": "202009221454",
			"scmRevision": ""
		},
		{
			"name": "sap.ui.core",
			"version": "1.80.0",
			"buildTimestamp": "202009221454",
			"scmRevision": ""
		},
		{
			"name": "sap.ui.layout",
			"version": "1.80.0",
			"buildTimestamp": "202009221454",
			"scmRevision": ""
		},
		{
			"name": "sap.ui.unified",
			"version": "1.80.0",
			"buildTimestamp": "202009221454",
			"scmRevision": ""
		}
	]
}

tobiasso85 avatar Sep 22 '20 12:09 tobiasso85