openui5 icon indicating copy to clipboard operation
openui5 copied to clipboard
verified publisher icon SAP

sap.m.upload.FilePreviewDialog doesn't show preview for mimetype image/jpg

Open geert-janklaps opened this issue 1 year ago • 1 comments

OpenUI5 version: 1.24.1

Browser/version (+device/version): Microsoft Edge, Google Chrome, Safari

Any other tested browsers/devices(OK/FAIL): Windows, Iphone

Steps to reproduce the problem: Currently the file preview dialog doesn't preview a jpg files if the mimetype is set to image/jpg, because the expected mimetype for a jpg file is image/jpeg. (hardcoded in the FilePreviewDialog, see referenced line below) Some systems set the mimetype for a jpg file to image/jpg (for example SAP Service Cloud).

https://github.com/SAP/openui5/blob/9c11476b266b8c68b007386a0260c09638bb451b/src/sap.m/src/sap/m/upload/FilePreviewDialog.js#L28

What is the expected result? A preview to be show if the mimetype is image/jpg (same as image/jpeg)

What happens instead? The file preview not available placeholder is shown

geert-janklaps avatar Jun 07 '24 17:06 geert-janklaps

Hi,

Could you guide us through the steps on how to recreate it?

Best, Teo

TeodorTaushanov avatar Jun 10 '24 09:06 TeodorTaushanov

Hello @geert-janklaps,

is there any update on the request by @TeodorTaushanov?

Best regards, Viktor

SAPUI5 GitHub Dispatcher

viktorsperling avatar Aug 07 '24 11:08 viktorsperling

Since there is no response from the author for more than 4 weeks I'm closing the ticket.

kskondov avatar Sep 04 '24 10:09 kskondov