openui5 icon indicating copy to clipboard operation
openui5 copied to clipboard
verified publisher icon SAP

Improve TS Types / JSDoc Issues for Calendar Controls

Open BenReim opened this issue 2 years ago • 1 comments

OpenUI5 version: 1.114.0

Issue API methods of the SinglePlanningCalendar, PlanningCalendar control return an object , when the return type should be Date | UI5Date

https://sdk.openui5.org/api/sap.m.PlanningCalendar

  • maxDate
  • minDate
  • startDate

https://sdk.openui5.org/api/sap.m.SinglePlanningCalendar

  • startDate

BenReim avatar Jun 06 '23 12:06 BenReim

Hello @BenReim , Thank you for sharing this finding. Even though I am not sure if such a change could be considered backward compatible I've created an internal incident 2380063108 in order to be processes by the team owning the controls. The status of the issue will be updated here in GitHub.

Regards, Elena Github Dispatcher

elenastoyanovaa avatar Jun 07 '23 12:06 elenastoyanovaa

Hey @BenReim,

Thanks again for sharing, the issue is now fixed with the commit linked above and will be available in UI5 version 1.125.

Best, Diana

didip1000 avatar May 22 '24 11:05 didip1000