fundamental-react icon indicating copy to clipboard operation
fundamental-react copied to clipboard

Update the selected state when props change: Select

Open skvale opened this issue 5 years ago • 0 comments

Description

Similar to https://github.com/SAP/fundamental-react/pull/1193 other components will need to respond to changes of the selected state after the initial render.

The Select has state that is set by a prop here: https://github.com/SAP/fundamental-react/blob/master/src/Select/Select.js#L49

The MultiInput has a state here: https://github.com/SAP/fundamental-react/blob/master/src/MultiInput/MultiInput.js#L26 https://github.com/SAP/fundamental-react/issues/1208

The state is not controlled by future prop changes.

Versions

fundamental-react:


NOTE: Where applicable, please include uncropped screen captures.

DISCLAIMER: After triaging an issue, the fundamental-react team will see if it can be reproduced or confirmed. If more information is needed, the fundamental-react team will contact the author. Any issues awaiting responses from the author for more than 7 days will be closed. The author can re-open the issue at a later time if they can present the requested information.

skvale avatar Sep 08 '20 16:09 skvale